mail attach update #1134
Merged
mail attach update #1134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dependency library imbox changed martinrusev/imbox@7c6cc2f#diff-1ae09572064c2e7c225de54ad5b49154 it propageted to pypi last week
e3rd
force-pushed
the
mail_collector_patch
branch
from
2b7bf1f
to
ffe6688
Compare
Codecov Report
@@ Coverage Diff @@
## develop #1134 +/- ##
===========================================
+ Coverage 75.14% 75.16% +0.02%
===========================================
Files 223 223
Lines 9700 9697 -3
Branches 1321 1320 -1
===========================================
Hits 7289 7289
+ Misses 2110 2108 -2
+ Partials 301 300 -1
|
ghost
self-requested a review
for older imbox versions and document it
ghost
suggested changes
Dec 11, 2017
There was a problem hiding this comment.
Thanks for noticing this change! I overlooked it.
Unfortunately we can't easily query the version for different behavior. I opened martinrusev/imbox#112 for that.
However IMO we can support older versions too, not only the very latest. I opened CZ-NIC#7 for that.
I will backport/"move" that change to 1.0.x, after it is merged.
ENH+DOC: mail attach collector: filename parsing
|
Merged ✓ :) You thing you overlooked it? How could you notice such a change in an external library? :o I've discovered it be mere accident. |
e3rd
added a commit
to CZ-NIC/intelmq
that referenced
this pull request
Dec 12, 2017
e3rd
added a commit
to CZ-NIC/intelmq
that referenced
this pull request
Dec 12, 2017
ghost
mentioned this pull request
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dependency library imbox changed
martinrusev/imbox@7c6cc2f#diff-1ae09572064c2e7c225de54ad5b49154
it propageted to pypi last week