small run_mode fixes and checks #1140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 18, 2017 14:08
not stream, but does not make a difference
ghost
added
Codecov Report
@@ Coverage Diff @@
## maintenance #1140 +/- ##
===============================================
+ Coverage 75.28% 75.69% +0.41%
===============================================
Files 217 217
Lines 9244 9435 +191
Branches 1248 1329 +81
===============================================
+ Hits 6959 7142 +183
- Misses 1999 2001 +2
- Partials 286 292 +6
|
|
Got no feedback, so probably ok |
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the default run_mode is called continuous according to docs, in lib/bot it was stream
and add a check for this parameter in ctl check