Return value of restart command #1226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e3rd
force-pushed
the
intelmqctl-restart-return
branch
from
d76ed4e
to
f9ffeb7
Compare
ghost
self-assigned this
e3rd
force-pushed
the
intelmqctl-restart-return
branch
from
f9ffeb7
to
390f30e
Compare
|
What's all the |
|
On 2018-04-15 13:13, Edvard Rejthar wrote:
What's all the |Optional key 'naics' not found data| errors please? I
hope I have nothing in common with this errors and the PR is alright.
I will look into it on Monday. Shadowserver parser (test) problem (I
suspect the testdata is out of date).
|
|
(I didn't intend to disturb you on week-end, of course that's a next weeks business :) ) |
ghost
self-requested a review
ghost
added
bug
ghost
suggested changes
Apr 16, 2018
Both start and stop command returned tuple (exit-status, string). Restart command returned ((exit-status-of-stop, string-of-stop), (exit-status-of-start, string-of-start)). Since exit-status was a tuple instead of a number, in the terminal error pipe received that tuple. Since intelmq-manager read only output-pipe, it wasn't aware of this incorrect behaviour. With my another pull request, intelmq-manager now handles error-pipe too, so that restart command stopped working. Old wrong behaviour: www-data@jezevec:~$ PATH=~/.local/bin intelmqctl restart abuse-ch-feodo-tracker-domains-parser intelmqctl: abuse-ch-feodo-tracker-domains-parser was NOT RUNNING. intelmqctl: Starting abuse-ch-feodo-tracker-domains-parser... intelmqctl: abuse-ch-feodo-tracker-domains-parser is running. (0, 'stopped') www-data@jezevec:~$ PATH=~/.local/bin intelmqctl --type json restart abuse-ch-feodo-tracker-domains-parser [0, "running"] (0, 'stopped') New correct behaviour: www-data@jezevec:~$ PATH=~/.local/bin intelmqctl restart abuse-ch-feodo-tracker-domains-parser intelmqctl: Stopping abuse-ch-feodo-tracker-domains-parser... intelmqctl: abuse-ch-feodo-tracker-domains-parser is stopped. intelmqctl: Starting abuse-ch-feodo-tracker-domains-parser... intelmqctl: abuse-ch-feodo-tracker-domains-parser is running. www-data@jezevec:~$ PATH=~/.local/bin intelmqctl --type json restart abuse-ch-feodo-tracker-domains-parser ["stopped", "running"]
e3rd
force-pushed
the
intelmqctl-restart-return
branch
from
390f30e
to
a3106a1
Compare
|
force-pushed with changelog |
ghost
approved these changes
Apr 16, 2018
|
Thanks! |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both start and stop command returned tuple (exit-status, string). Restart command returned ((exit-status-of-stop, string-of-stop), (exit-status-of-start, string-of-start)). Since exit-status was a tuple instead of a number, in the terminal error pipe received that tuple. Since intelmq-manager read only output-pipe, it wasn't aware of this incorrect behaviour. With my another pull request, intelmq-manager now handles error-pipe too, so that restart command stopped working.
Old wrong behaviour:
New correct behaviour:
Note that the return value reflects both operations,
bot_startandbot_stopas seems intended by previous programmer.