Shadowserver parser: mapping for Honeypont HTTP Scan and updated Microsoft Sinkhole HTTP #2050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolved the following error that Could not get a configuration for: event4_honeypot_http_scan event4_microsoft_sinkhole_http
ghost
reviewed
Aug 19, 2021
Comment on lines
2962
to
+2963
| ('Microsoft-Sinkhole-Events-HTTP IPv4', 'event4_microsoft_sinkhole_http', event46_sinkhole_http), | ||
| ('Microsoft_sinkhole_http', 'event4_microsoft_sinkhole_http', event4_microsoft_sinkhole_http), |
There was a problem hiding this comment.
These two lines have the same file name pattern. If there's a mistake in the event46_sinkhole_http mapping, please fix this one.
|
Regarding the honeypot feed it looks like you worked on that approximately at the same time as @monoidic (#2047). His mapping looks cleaner to me. However, if you could provide test cases for his PR, I bet he'd be happy :) Regarding the other change on the Microsoft Sinkhole HTTP feed, I don't understand the intent of the change, see also my inline comment. |
ghost
changed the title
ghost
mentioned this pull request
Closed
ghost
closed this
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved the following error that Could not get a configuration for:
event4_honeypot_http_scan
event4_microsoft_sinkhole_http