FIX: Updates Turris Greylist parser and feed URL. #2373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gethvi
force-pushed
the
fix-turris-greylist
branch
4 times, most recently
from
ce305c5
to
b11d93b
Compare
sebix
requested changes
Jun 9, 2023
gethvi
force-pushed
the
fix-turris-greylist
branch
from
b11d93b
to
bcdfa27
Compare
sebix
approved these changes
Jun 13, 2023
sebix
reviewed
Jun 13, 2023
| @@ -887,7 +900,7 @@ def v310_feed_changes(configuration, harmonization, dry_run, **kwargs): | |||
| ((3, 0, 1), (v301_deprecations,)), | |||
| ((3, 0, 2), ()), | |||
| ((3, 1, 0), (v310_feed_changes, v310_shadowserver_feednames)), | |||
| ((3, 2, 0), ()), | |||
| ((3, 2, 0), (v320_update_turris_greylist_url)), | |||
There was a problem hiding this comment.
That line misses a trailing comma to make it a tuple:
((3, 2, 0), (v320_update_turris_greylist_url, )),
Upgrading to version 3.2.0.
File "/opt/hostedtoolcache/Python/3.11.4/x64/lib/python3.11/site-packages/intelmq/bin/intelmqsetup.py", line 184, in intelmqsetup_core
controller.upgrade_conf(state_file=state_file, no_backup=True)
File "/opt/hostedtoolcache/Python/3.11.4/x64/lib/python3.11/site-packages/intelmq/bin/intelmqctl.py", line 1152, in upgrade_conf
for function in bunch:
TypeError: 'function' object is not iterable
There was a problem hiding this comment.
Fix of the fix incoming in few...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2167.