Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

Adds HPA and support for local https sites #16

Merged
merged 4 commits into from
Oct 20, 2021

Conversation

digiserg
Copy link
Contributor

@digiserg digiserg commented Oct 4, 2021

I'm using swagger UI with a local service that exposes a https endpoint. As it's running in the same kubernetes cluster and namespace I can access it with https://SERVICE-NAME. Unfortunately the wget command fails because it's not a FQDN and the SSL verification cannot be done.

I'm also adding the HPA template for users wanting to do autoscaling.

@banzo
Copy link
Contributor

banzo commented Oct 20, 2021

@digiserg we have set the ssl check flag as an option in the values.yaml but we cannot update the PR, can you authorize us as explained here: https://docs.github.com/en/github/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork#enabling-repository-maintainer-permissions-on-existing-pull-requests ?

@digiserg
Copy link
Contributor Author

Hi @banzo

Unfortunately, I can't, this is an org account and I don't have permissions. If you send me the changes I'll include them and you can merge them.

Thanks

@banzo
Copy link
Contributor

banzo commented Oct 20, 2021

You can find our proposed changes at https:/cetic/helm-swagger-ui/tree/feature/sslcheckskip

Copy link
Contributor

@SellamiRami SellamiRami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding the jsonNoCheckCertificate feature in the Helm chart is reviewed and approaved

@SellamiRami SellamiRami merged commit e46ca44 into cetic:master Oct 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants