Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for else case #137

Closed
lucaswerkmeister opened this issue Aug 22, 2017 · 1 comment
Closed

Add support for else case #137

lucaswerkmeister opened this issue Aug 22, 2017 · 1 comment
Labels
feature
Milestone
1.3.3

Comments

@lucaswerkmeister
Copy link
Member

See eclipse-archived/ceylon#6806.
@lucaswerkmeister lucaswerkmeister added this to the Next release milestone Aug 22, 2017
lucaswerkmeister added a commit that referenced this issue Sep 28, 2017
@lucaswerkmeister
Add support for else case (non-disjoint cases)
13f3705 
Fixes part of #137, but the compiler also supports `else case` in switch
expressions, so ceylon.ast should probably support that too, even though
it’s not in the specification as of Ceylon 1.3.3.

Note that due to the inclusion of a non-disjoint case clause in
completeCompilationUnit, the completeCompilationUnit-related tests need
a ceylon.formatter version with a fix for eclipse-archived/ceylon.formatter#141.
Since the 1.3.3 release branch of ceylon.formatter was cut too early,
there is no public tree of ceylon.formatter with a fix for that issue
and also the version number 1.3.3-SNAPSHOT (as imported by
test.ceylon.ast.redhat); you can get one locally by checking out
ceylon.formatter’s 1.3.3 release tag and then reverting the version
update commit (eclipse-archived/ceylon.formatter@a30506b4ab).
@lucaswerkmeister
Copy link
Member Author

Done for switch statements, but the compiler also supports it for switch expressions.

lucaswerkmeister added a commit that referenced this issue Oct 3, 2017
@lucaswerkmeister
Update CaseClause.hash for elseCase flag (#137)
b31759a 
Updating node types is tricky – there are lots of places that need to be
updated, and many of them don’t cause any errors if you forget. I’ve
created the wiki page “changing nodes” to list all these places so that
this hopefully doesn’t happen again in the future.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
1.3.3
Development

No branches or pull requests
1 participant
@lucaswerkmeister