Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make Visitor not satisfy WideningTransformer #109

Closed
wants to merge 1 commit into from

Commits on Dec 13, 2015

  1. make Visitor not satisfy WideningTransformer

    Visitors that satisfy WideningTransformer turn out to be measurably slower than
    WideningTransformer's themselves. This commit makes Visitor independent of
    WideningTransformer for a nice speed boost.
    
    Steps to recreate the bulk of this patch:
    
    1. Open the nodes in vi:
        vi `grep -l 'shared actual Result transform' * \
            | grep -v SelfReference`
    
    2. Record a macro:
        - qq // start recording
        - /shared actual Result transform // find transform()
        - <shift-v>jjy // highlight & copy
        - jj // move down
        - p // paste
        - DAshared actual void visit(Visitor visitor)
        - <esc>j
        - :s/transformer/visitor
        - :s/transform/visit
        - jhhhD // whitespace
        - q // stop recording
    
    3. Undo changes (uuuuuuuuuuuuu)
    
    4. Move to top of file (:1)
    
    5. Execute macro on all files:
        :bufdo execute "normal @q" | write
    
    6. :q
    
    7. Manually fix
        - SelfReference.ceylon
        - Identifier.ceylon
    jvasileff committed Dec 13, 2015
    Configuration menu
    Copy the full SHA
    72c5f2f View commit details
    Browse the repository at this point in the history