Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add desktop electron project #136

Merged

Conversation

cfu288
Copy link
Owner

@cfu288 cfu288 commented Nov 8, 2023

No description provided.

Copy link

linear bot commented Nov 8, 2023

MAR-67 Add electron build for desktop windows and mac

This was something I attempted to do a while back, but something I should revisit

Copy link

gitguardian bot commented Feb 20, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
9650072 Triggered Okta Keys dcf06bd apps/web/src/environments/config.electron.json View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@cfu288 cfu288 force-pushed the feature/mar-67-add-electron-build-for-desktop-windows-and-mac branch from 4b74d9b to d524c3d Compare February 23, 2024 17:15
@cfu288 cfu288 merged commit 4f6c4e2 into main Mar 2, 2024
4 checks passed
@cfu288 cfu288 deleted the feature/mar-67-add-electron-build-for-desktop-windows-and-mac branch March 2, 2024 22:52
@cfu288 cfu288 restored the feature/mar-67-add-electron-build-for-desktop-windows-and-mac branch March 3, 2024 05:49
cfu288 added a commit that referenced this pull request Mar 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant