Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support request timeouts #25

Merged
merged 6 commits into from
Nov 3, 2023
Merged

Support request timeouts #25

merged 6 commits into from
Nov 3, 2023

Conversation

solidoracle
Copy link
Contributor

fixes #16

mempirate
mempirate requested changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@mempirate mempirate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I requested a couple of changes. Could you also add some tests to make sure everything is working correctly?

msg-socket/src/req/driver.rs Show resolved Hide resolved
msg-socket/src/req/driver.rs Outdated Show resolved Hide resolved
msg-socket/src/req/mod.rs Outdated Show resolved Hide resolved
msg-socket/src/req/socket.rs Outdated Show resolved Hide resolved
mempirate
mempirate requested changes Nov 2, 2023
View reviewed changes
msg-socket/src/req/driver.rs Outdated Show resolved Hide resolved
msg-socket/src/req/driver.rs Outdated Show resolved Hide resolved
mempirate
mempirate approved these changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@mempirate mempirate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! I added some minor changes & merged with main, thank you for the PR!

@mempirate mempirate merged commit 44d5484 into chainbound:main Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mempirate mempirate mempirate approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support request timeouts
2 participants
@solidoracle @mempirate