Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(qol): use ToSocketAddrs for public-facing socket apis #64

Merged
merged 2 commits into from
Jan 22, 2024
Merged

feat(qol): use ToSocketAddrs for public-facing socket apis #64

merged 2 commits into from
Jan 22, 2024

Conversation

merklefruit
Copy link
Contributor

@merklefruit merklefruit commented Jan 21, 2024 •
edited
Loading

Breaking changes

  • API interface: bind and connect socket methods now accept a simple &str instead of SocketAddr. This does dns resolution in the background as well.

@merklefruit merklefruit self-assigned this Jan 21, 2024
@merklefruit merklefruit added C-feature Category: Feature S-breaking Status: Contains breaking changes A-socket Area: Sockets labels Jan 21, 2024
mempirate
mempirate approved these changes Jan 22, 2024
View reviewed changes
Copy link
Contributor

@mempirate mempirate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LFG, much cleaner API

mempirate
mempirate requested changes Jan 22, 2024
View reviewed changes
Copy link
Contributor

@mempirate mempirate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update the book as well? Forgot about that

@merklefruit
Copy link
Contributor Author

Could you update the book as well? Forgot about that

Actually all the examples in the book already used this feature for some reason haha
I can add a few lines to explain that it does auto dns resolution though

mempirate
mempirate approved these changes Jan 22, 2024
View reviewed changes
Copy link
Contributor

@mempirate mempirate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@mempirate mempirate merged commit 1ebdc7d into main Jan 22, 2024
7 checks passed
@mempirate mempirate deleted the feat/tosocketaddrs branch January 22, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mempirate mempirate mempirate approved these changes

Assignees

@merklefruit merklefruit

Labels
A-socket Area: Sockets C-feature Category: Feature S-breaking Status: Contains breaking changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

qol: use ToSocketAddrs trait for connections
2 participants
@merklefruit @mempirate