debug: Add loggin before/after various routing functions #1048
Conversation
There was a problem hiding this comment.
Accepting, but the const origDestStr = ${odTrip.attributes.origin_geography.coordinates.join(',')} to ${odTrip.attributes.destination_geography.coordinates.join(',')};
that repeats in many place would benefit being in a function that simply both the origin and destination
| @@ -145,7 +145,8 @@ class TrRoutingBatch { | |||
| console.log( | |||
| 'calc/sec', | |||
| Math.round( | |||
| (100 * completedRoutingsCount) / ((1 / 1000) * (performance.now() - benchmarkStart)) | |||
| (100 * (completedRoutingsCount - startIndex)) / | |||
There was a problem hiding this comment.
This is starting to get complex, would benefit having a comment
| @@ -123,7 +123,10 @@ export class Routing { | |||
| // ** backend | |||
| const routingPromises: Promise<TransitOrRouteCalculatorResult>[] = []; | |||
|
|
|||
| console.log(`Routing beginning with ${routingAttributes.routingModes.length} modes`); | |||
| const origDestStr = `${routingAttributes.originGeojson.geometry.coordinates.join(',')} to ${routingAttributes.destinationGeojson.geometry.coordinates.join(',')}`; | |||
There was a problem hiding this comment.
could be nice to be in a "toString" function instead
When a job starts from a checkpoint, we need to substract the `startIndex` from the `completedRoutingCount` to get the actual of calculations done, otherwise we get slowly decreasing results.
To investigate issue chairemobilite#1011 on instances, we add logs before and after the calculation functions, each individual mode calculation and the trRouting requests. The log messages include the origin/destination coordinates to allow to track individual queries. These can be matched with the odTripIndex from a log message in the batch routing task.
|
Added a comment for calculation, I'll open an issue for the utility function, as we may not necessarily want to keep the logs as is for the future. This is for very short term debugging |
Ok. But printing an OD pair seems to be a very useful things for us in general! |
To investigate issue #1011 on instances, we add logs before and after
the calculation functions, each individual mode calculation and the
trRouting requests. The log messages include the origin/destination
coordinates to allow to track individual queries. These can be matched
with the odTripIndex from a log message in the batch routing task.