Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: IsQuitCmd & IsQuitMsg #723

Closed
wants to merge 1 commit into from
Closed

feat: IsQuitCmd & IsQuitMsg #723

wants to merge 1 commit into from

Conversation

caarlos0
Copy link
Member

Allows to check if the given command/message will cause the application
to quit.

Extracted from #352

@caarlos0
feat: IsQuitCmd & IsQuitMsg
a84077e 
Allows to check if the given command/message will cause the application
to quit.

Extracted from #352
@caarlos0 caarlos0 self-assigned this Apr 17, 2023
@caarlos0 caarlos0 marked this pull request as ready for review April 17, 2023 14:46
@caarlos0 caarlos0 added the enhancement New feature or request label Apr 17, 2023
@muesli
Copy link
Contributor

muesli commented Apr 17, 2023

Heads up: I'm still leaning towards making QuitMsg public: https:/charmbracelet/bubbletea/pull/536/files

Might be the nicer solution instead of adding public API we'll eventually deprecate again.

@meowgorithm
Copy link
Member

Considering BatchMsg is public now I don't see why QuitMsg shouldn't be public. In general I think #536 is fine to be merged at this point.

@muesli
Copy link
Contributor

muesli commented Apr 17, 2023

Superseeded by #536.

@muesli muesli closed this Apr 17, 2023
@caarlos0 caarlos0 deleted the is-quit branch April 17, 2023 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meowgorithm meowgorithm Awaiting requested review from meowgorithm meowgorithm is a code owner

@muesli muesli Awaiting requested review from muesli

Assignees

@caarlos0 caarlos0

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@caarlos0 @muesli @meowgorithm