Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#10896): correct typing for doughnut, pie, and polarArea charts #11521

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

DustinEwan
Copy link

This is a change to DoughnutAnimationOptions to base the interface off of AnimationSpec<"doughnut">.

This appears to be the correct choice as a few of the existing tests include animation options in various doughnut based charts and include properties such as delay and easing which are missing from DoughnutAnimationOptions but are present in the AnimationSpec interface.

Also includes a basic test that ensures that DoughnutAnimationOptions is fully assignable to ChartOptions<"doughnut">

@LeeLenaleee LeeLenaleee added the type: types Typescript type changes label Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: types Typescript type changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants