Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/issue 11804 tooltip show for all invisible #11858

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/elements/element.arc.ts
Original file line number Diff line number Diff line change
Expand Up @@ -324,7 +324,8 @@ export default class ArcElement extends Element<ArcProps, ArcOptions> {
], useFinalPosition);
const rAdjust = (this.options.spacing + this.options.borderWidth) / 2;
const _circumference = valueOrDefault(circumference, endAngle - startAngle);
const betweenAngles = _circumference >= TAU || _angleBetween(angle, startAngle, endAngle);
const nonZeroBetween = _angleBetween(angle, startAngle, endAngle) && startAngle !== endAngle;
const betweenAngles = _circumference >= TAU || nonZeroBetween;
const withinRadius = _isBetween(distance, innerRadius + rAdjust, outerRadius + rAdjust);

return (betweenAngles && withinRadius);
Expand Down
22 changes: 22 additions & 0 deletions test/specs/element.arc.tests.js
Original file line number Diff line number Diff line change
Expand Up @@ -281,4 +281,26 @@ describe('Arc element tests', function() {

expect(ctx.getCalls().length).toBeGreaterThan(0);
});

it ('should determine not in range when angle 0', function() {
// Mock out the arc as if the controller put it there
var arc = new Chart.elements.ArcElement({
startAngle: 0,
endAngle: 0,
x: 0,
y: 0,
innerRadius: 0,
outerRadius: 10,
circumference: 0,
options: {
spacing: 0,
offset: 0,
borderWidth: 0
}
});

var center = arc.getCenterPoint();

expect(arc.inRange(center.x, 1)).toBe(false);
});
});
Loading