parent() may fail in functions

[5saviahv]

parent() don't work well in functions if selector is undefined

function getParent(el, parent) {
    return el.parent(parent).not('body');
}

var parent = getParent($('#rating span'))

In .parent() has condition:

...
  if (arguments.length) {
...

but it will fail if used like in function above, since arguments.length will be 1 even when selector is actually undefined.

[XhmikosR]

This reminds me, shouldn't everything run in strict mode?

[fb55]

Nice find! Happy to merge this, just out of curiosity: Is this actually a fix, or just a short-circuit for an empty input?

[5saviahv]

What do you mean ? arguments variable is array like, I would call arguments.length a hack.

[fb55]

What I was trying to get at was does this actually produce an error? And yes, it does:

$('<a>').parent(undefined)
// => Uncaught TypeError: Cannot read property 'cheerio' of undefined

Could you add a test case that covers this?

[fb55]

Awesome, thanks!