Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowable values for --ebs-volume-type should state "standard (magnetic) | io1 | gp2 | sc1 | st1" #450

Closed
rjhintz opened this issue Nov 14, 2016 · 3 comments

Comments

@rjhintz
Copy link

rjhintz commented Nov 14, 2016

Change ec2_server_create.rb

 option :ebs_volume_type,
        :long => "--ebs-volume-type TYPE",
        :description => "Standard or Provisioned (io1) IOPS or General Purpose (gp2)",
        :proc => Proc.new { |key| Chef::Config[:knife][:ebs_volume_type] = key },
        :default => "standard"

to:

 option :ebs_volume_type,
        :long => "--ebs-volume-type TYPE",
        :description => "standard (magnetic) | io1 | gp2 | sc1 | st1",
        :proc => Proc.new { |key| Chef::Config[:knife][:ebs_volume_type] = key },
        :default => "standard"

to align with AWS CLI run-instances.

This assumes the AWS EBS disk type abbreviations such as gp2 are generally understood.

Default value should also be changed from standard (magnetic) to gp2 (SSD) to align with current AWS practice. However, this is a disruptive change for current code. I'll propose this separately.

See also #451. I have to do the prerequisite admin to do a PR, but didn't want this to get lost.

@dheerajd-msys
Copy link
Contributor

@rjhintz Thanks for your comments. We will get it fixed soon.

@rjhintz
Copy link
Author

rjhintz commented Dec 9, 2016

Ok, thanks. I couldn't figure out how to do a PR because the method for becoming a contributor seems obsolete. See #452

@NimishaS
Copy link

Fixed in #464

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants