Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added validation when spot-wait-mode option is given by user on CLI and spot-price option is not given. #429

Merged

Conversation

Aliasgar16
Copy link

Done.

@@ -891,6 +891,11 @@ def validate!
end
end

if locate_config_value(:spot_price).nil? && locate_config_value(:spot_wait_mode).downcase != 'prompt'
ui.error('spot-wait-mode option works only with the spot-price option.')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"spot-wait-mode option requires that a spot-price is set."

@btm
Copy link
Contributor

btm commented Jul 25, 2016

Please merge #427 and rebase this to fix Gem::InstallError: rack requires Ruby version >= 2.2.2. and make sure this passes travis, then 👍 to merge.

@NimishaS NimishaS force-pushed the ali/add_validation_for_spot_wait_mode branch from 46b117e to e538f10 Compare July 26, 2016 07:08
@NimishaS NimishaS merged commit 6114101 into chef:master Jul 26, 2016
@NimishaS NimishaS deleted the ali/add_validation_for_spot_wait_mode branch July 26, 2016 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants