Evaluating ec2 server attributes in node name #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@harikesh-kolekar can you rebase this please? |
added 4 commits
January 30, 2017 17:36
Signed-off-by: harikesh-kolekar <[email protected]>
Signed-off-by: harikesh-kolekar <[email protected]>
Signed-off-by: harikesh-kolekar <[email protected]>
Signed-off-by: harikesh-kolekar <[email protected]>
harikesh-kolekar
force-pushed
the
hk/eval_node_name
branch
from
8cdb259
to
6cae8e9
Compare
|
This looks good. @btm , please review. |
btm
approved these changes
Feb 3, 2017
|
@harikesh-kolekar please create another PR that updates preps RELEASE_NOTES.md, DOC_CHANGES.md, and CHANGELOG.md for an 0.15 release, and describes how to use this feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
w.r.t. #292