[MSYS-677] Add --instance-initiated-shutdown-behavior option
#514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cory Stephenson <[email protected]>
Signed-off-by: NAshwini <[email protected]>
btm
reviewed
Nov 22, 2017
| @@ -453,6 +453,10 @@ class Ec2ServerCreate < Knife | |||
| :boolean => true, | |||
| :default => false | |||
|
|
|||
| option :instance_initiated_shutdown_behavior, | |||
| :long => "--instance-initiated-shutdown-behavior STUTDOWN_BEHAVIOR", | |||
There was a problem hiding this comment.
there's a typo here in STUTDOWN -> SHUTDOWN
btm
reviewed
Nov 22, 2017
| @@ -133,7 +133,8 @@ | |||
| :request_type => 'persistent', | |||
| :placement_group => nil, | |||
| :iam_instance_profile_name => nil, | |||
| :ebs_optimized => "false" | |||
| :ebs_optimized => "false", | |||
| :instance_initiated_shutdown_behavior=>nil | |||
There was a problem hiding this comment.
:instance_initiated_shutdown_behavior => nil
NAshwini
added a commit
to MsysTechnologiesllc/knife-ec2
that referenced
this pull request
Nov 23, 2017
Signed-off-by: NAshwini <[email protected]>
NAshwini
changed the title
--instance-initiated-shutdown-behavior option--instance-initiated-shutdown-behavior option
NimishaS
pushed a commit
that referenced
this pull request
Nov 23, 2017
…_behavior [MSYS-677] Fix the review comments for the PR #514
|
Will there be a minor release to publish this soon? It's been a few months |
|
Yes @sethrosenblum , we are releasing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an option in
knife-ec2to set the--instance-initiated-shutdown-behaviorwith the option to set"stop"or"terminate". The default is"stop".cheery-pick the contains from PR: #507 .
Made changes as per review comments to work functionality successfully.
Tested with command: