If no keys specified on CLI/config use an AWS credential file if present #548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was huge and hard to follow Signed-off-by: Tim Smith <[email protected]>
AWS keys on the CLI and in knife.rb will continue to take precedent, but if you specify nothing on the CLI now we'll go looking for a credentials file and if we find it we'll use those credentials. In 2016 people should be using the credentials file unless they have a need to override those values so this makes that easy. Signed-off-by: Tim Smith <[email protected]>
Signed-off-by: Tim Smith <[email protected]>
We can't double validate the config since it loads the values when we do that and then we fail the config file + keys scenario later on. side note: why does validation load config values into the config hash. That seems like a bad idea Make sure to load the correct config in the credentials loading method Signed-off-by: Tim Smith <[email protected]>
Getting a generic ruby error isn't really delightful. Signed-off-by: Tim Smith <[email protected]>
Signed-off-by: Tim Smith <[email protected]>
Signed-off-by: Tim Smith <[email protected]>
tas50
changed the title
tas50
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now we require the user to specify the location to the aws credentials file, but the file has a standard location. This moves us to a model where that credentials file is the standard source of credentials unless otherwise specified. In 2018 that seems like a sane expectation since ~/.aws/credentials is the standard aws location for creds now.
This also breaks up the insane validate! method into 3 methods so you can more easily follow the logic. It was getting crazy.
Finally it gives more friendly error messages if the specified config/credential file location doesn't actually exist so you don't just get a Ruby error message.