Remove deprecated options & set default value for ec2 ami list owner option #586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
we can deprecate at some point we should switch code to use the other pattern, but for now the deprecation message should point out the difference. |
|
Hey @btm Thanks for reviews comment I have deprecated |
Nimesh-Msys
suggested changes
Jul 5, 2019
kvivek1115
force-pushed
the
VSingh/remove-deprecated-options
branch
from
6921e31
to
0b53eaf
Compare
added 5 commits
July 9, 2019 11:24
- --tags now available in chef core and has been removed from knife-ec2. - Removed options --tag-node-in-chef and --security-group-ids. Signed-off-by: Vivek Singh <[email protected]>
Signed-off-by: Vivek Singh <[email protected]>
Signed-off-by: Vivek Singh <[email protected]>
Signed-off-by: Vivek Singh <[email protected]>
- AMI list removes the unwanted comment and put "aws-marketplace" in option default. - Rename tags method with parse_aws_tags for aws_tag option. - Minor specs fix. Signed-off-by: Vivek Singh <[email protected]>
kvivek1115
force-pushed
the
VSingh/remove-deprecated-options
branch
from
0b53eaf
to
59b92d8
Compare
kvivek1115
changed the title
added 5 commits
July 9, 2019 11:45
Signed-off-by: Vivek Singh <[email protected]>
Signed-off-by: Vivek Singh <[email protected]>
Signed-off-by: Vivek Singh <[email protected]>
Signed-off-by: Vivek Singh <[email protected]>
Signed-off-by: Vivek Singh <[email protected]>
kvivek1115
force-pushed
the
VSingh/remove-deprecated-options
branch
from
a5d69dd
to
a5e2966
Compare
btm
approved these changes
Jul 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
--tag-node-in-chefand--security-group-ids--tagsalso deprecated but available in chef-core so--tagsremoved from knife-ec2.--tagsand--chef-tagdo the same things so we can also deprecated--chef-tagfrom knife-ec2 plugin?Check List