Add connection debug information #596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lamont-granquist
approved these changes
Jul 8, 2019
I was having a really hard time getting this plugin to work on my system. I thought I could run the plugin in debug, but that didn't provide any connection information. I added debug statements to various parts of the connection setup and I improved the error when the aws profile is missing from your credentials file, which is what my error actually was. This will result in secret keys being written to the terminal, but there isn't really a way around that when someone runs a cloud plugin in debug. Signed-off-by: Tim Smith <[email protected]>
I should have known this was going to break something Signed-off-by: Tim Smith <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was having a really hard time getting this plugin to work on my
system. I thought I could run the plugin in debug, but that didn't
provide any connection information. I added debug statements to various
parts of the connection setup and I improved the error when the aws
profile is missing from your credentials file, which is what my error
actually was. This will result in secret keys being written to the
terminal, but there isn't really a way around that when someone runs a
cloud plugin in debug.
Signed-off-by: Tim Smith [email protected]