Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Train SSH Connection Error #635

Merged
merged 1 commit into from
Jan 22, 2020

Conversation

kapilchouhan99
Copy link

Signed-off-by: Kapil Chouhan [email protected]

Description

  • When server.public_dns_name returns a blank string "", it tries to connect as a host, so due to this, it raises an error ERROR: Train::ClientError: You must provide a value for "host".. So I have fixed it by adding conditions.
  • Added test cases
  • Ensured chef-style on the code changes made

Issues Resolved

Fixes: #633

Check List

@tas50 tas50 merged commit e036e28 into master Jan 22, 2020
@chef-expeditor chef-expeditor bot deleted the Kapil/MSYS-1236_Train_SSH_Connection_Error branch January 22, 2020 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Train SSH Connection Error
2 participants