Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow creating intstances with ST1 or SC1 EBS volume types #660

Merged
merged 1 commit into from
Oct 21, 2020

Conversation

kapilchouhan99
Copy link

@kapilchouhan99 kapilchouhan99 commented Oct 21, 2020

Description

  • Users can create a VM with the Throughput Optimized HDD (st1) or Cold HDD (sc1) volume type.
  • Changed ebs_no_delete_on_term option as a ebs_delete_on_term boolean option and its default value is true, because earlier if we created any VM with st1 or sc1 volume type, then there is no option to delete this volume on instance termination.
  • Added test cases
  • Ensured cook-style on the code changes made

Related Issue

Fixes: #651

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

@kapilchouhan99 kapilchouhan99 force-pushed the Kapil/Github-651_cannot_create_any_VM_with_ST1_EBS branch from b00daa5 to 50b37be Compare October 21, 2020 11:46
@tas50 tas50 changed the title Fix for create any VM's with ST1 or SC1 types of HD/EBS Allow creating intstances with ST1 or SC1 EBS volume types Oct 21, 2020
@tas50 tas50 added the Expeditor: Bump Version Minor Used by github.minor_bump_labels to bump the Minor version number. label Oct 21, 2020
@tas50 tas50 merged commit fb0917c into master Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Expeditor: Bump Version Minor Used by github.minor_bump_labels to bump the Minor version number.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot create any VM's with ST1 (HDD Optimized) types of HD/EBS
2 participants