S3Source does not extend any Chef classes, so config is not an inherited attribute

[signe]

S3Source does not extend any Chef classes, so config is not an inherited attribute and as such needs to be passed in to fetch() explicitly

Description

All calls to S3Source.fetch were failing because none of the AWS access information was available using config attribute. (Modified in 2cc491d)

Also fixes rspec tests for S3Source which have been broken and untested for... a long time. At least since 2cc491d, but it appears much longer.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

• I have read the CONTRIBUTING document.
• I have run the pre-merge tests locally and they pass.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• All new and existing tests passed.
• All commits have been signed-off for the Developer Certificate of Origin.

[tas50]

Thanks @signe