Load collect_data() even if we've already seen it #1224
Conversation
If we happen to load a plugin with the same name twice, we refuse to run #collect_data but we still load the rest of the plugin, which means you get #collect_data from the first plugin and rest of the plugin from the last plugin. This makes it so you get #collect_data from the last plugin as well. I don't know how to use the logger from the class method so I fell back to `Ohai::Log`. Happy to fix that if someone knows the magic. Fixes #1212 Signed-off-by: Bryan McLellan <[email protected]>
|
Yeah, the better way would be to fail it hard in some way or other, but there might be a chicken+egg with chef being unable to clean it up once it got into this state. The ohai segment in cookbooks is probably the better way to fix this 'right'. At least here there's some hope that the collect_data from the last-parsed plugin will use the methods from the last-parsed plugin and that will be halfway sane, although technically the object is going to get monkeypatched multiple times... 👍 |
|
Agree this isn't ideal, but it's also an edge case. hopefully anyone going down this path see's the warning and then avoids having multiple plugins with the same name. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
If we happen to load a plugin with the same name twice, we refuse to run #collect_data but we still
load the rest of the plugin, which means you get #collect_data from the first plugin and rest of the
plugin from the last plugin.
This makes it so you get #collect_data from the last plugin as well.
I don't know how to use the logger from the class method so I fell back to
Ohai::Log. Happy to fix thatif someone knows the magic.
Fixes #1212
Signed-off-by: Bryan McLellan [email protected]