Fix the error message logged when omnibus failed to resolve refs to commits #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 21, 2013 15:02
… resolve refs to commits
|
👍 So awesome to see the test coverage also! |
schisamo
added a commit
that referenced
this pull request
Nov 22, 2013
Fix the error message logged when omnibus failed to resolve refs to commits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Thanks for sharing this!
I doubt that omnibus emits an incorrect message when it fails to resolve refs(typically specified via
versioninconfig/software/foo.rb) to commit IDs.I get "Failed to fetch git repository '#{@source[:git]}'", but what I think better is something like "Failed to find any commits for the ref '#{ref}'", since in this case omnibus did succeed to fetch.
This PR will fix the message while adding specs to GitFetcher to ensure that it work before and after the fix.
Regards,
Yusuke