Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ":file" to the list of supported sources #808

Merged
merged 2 commits into from
Feb 9, 2018

Conversation

legal90
Copy link
Contributor

@legal90 legal90 commented Jan 2, 2018

Description

That is a continuation of #795.
In order to use file fetcher in source DSL method of software, we need to add it to the list of valid arguments. Otherwise, the following error will occur:

Invalid value for `source'. Expected source to only include valid keys. Invalid keys: [:file]!

Use case:

# config/software/my_software.rb
# <...>

version("local_file") do
  source file: "../../my_dir/artifact.zip"
end

# <...>

@legal90 legal90 requested a review from a team as a code owner January 2, 2018 14:13
@legal90 legal90 force-pushed the fix-file-fetcher branch 2 times, most recently from 88fe242 to e1f8902 Compare January 2, 2018 14:15
Copy link
Contributor

@scotthain scotthain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@legal90
Copy link
Contributor Author

legal90 commented Jan 8, 2018

Thank you for the review!
I've added tests and TravisCI build passes fine. However, the Appveyor build fails, but it is not related to this changeset.

@scotthain
Copy link
Contributor

Hi @legal90 I believe we've resolved the appveyor issues in master - could you rebase this PR? Thanks!

@legal90 legal90 force-pushed the fix-file-fetcher branch 2 times, most recently from e29f467 to 5a1ae03 Compare January 29, 2018 06:48
@legal90
Copy link
Contributor Author

legal90 commented Jan 29, 2018

@scotthain Sure! I've rebased the branch.

@legal90
Copy link
Contributor Author

legal90 commented Feb 9, 2018

Just did it once again.

Copy link

@robbkidd robbkidd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thumbsup

@scotthain scotthain merged commit d1f32df into chef:master Feb 9, 2018
@scotthain
Copy link
Contributor

Thanks @legal90 - sorry it took so long to get things cleared up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants