Add config to allow rubygems publish and promote #816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scotthain
force-pushed
the
shain/tweak_config
branch
from
a81ad38
to
96adeef
Compare
tduffield
approved these changes
Jan 26, 2018
Signed-off-by: Scott Hain <[email protected]>
scotthain
force-pushed
the
shain/tweak_config
branch
from
96adeef
to
abb78d7
Compare
schisamo
suggested changes
Jan 30, 2018
| @@ -22,3 +25,7 @@ merge_actions: | |||
| - built_in:build_gem: | |||
| only_if: | |||
| - built_in:bump_version | |||
|
|
|||
| promote: | |||
| action: | |||
There was a problem hiding this comment.
Shouldn't this be:
artifact_actions:
promoted_to_stable:
- built_in:publish_rubygemsThat matches what we have in various other projects:
https:/chef/chef/blob/master/.expeditor/config.yml#L71-L73
https:/chef/chef-dk/blob/master/.expeditor/config.yml#L66-L68
https:/chef/inspec/blob/master/.expeditor/config.yml#L59-L60
There was a problem hiding this comment.
I talked to @tduffield about this - since we have no artifacts (rpms, etc) there is no 'artifact_action' for this, thus we need the promote primitive.
jaymalasinha
approved these changes
Jan 30, 2018
schisamo
approved these changes
Jan 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Scott Hain [email protected]
Description
@chef/jex-team
Maintainers
Please ensure that you check for:
serial number
corresponding change is reviewed and there is a release plan
corresponding change is reviewed and there is a release plan