Change exclude to use ** to skip levels
#834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
excludes I think overmatches due to a lack of FNM_PATHNAME. This is surprising to me, but may not be a bug depending on your expectations. Signed-off-by: Richard Clamp <[email protected]>
Here we adjust the tests and code to match what I expected should happen, that you want a '**' to skip levels when excluding, and for '*' to not match '/' Signed-off-by: Richard Clamp <[email protected]>
srenatus
approved these changes
Apr 13, 2018
|
💭 I do wonder, however, how many users potentially depend on |
|
Cucumber failures are the same as on master. 😭 |
|
This is still an issue that is biting us. What further needs to be done for this PR? |
lamont-granquist
approved these changes
Aug 2, 2019
|
Looks like CI may have stalled out. |
|
Thanks @richardc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As raised in #833 I find the current behaviour of exclude to be a little alarming, I expect the exclude
'start/*/end'to match'start/middle/end'but not'start/on/the/way/to/the/end'Here we specify File::FNM_PATHNAME to the fnmatch call, so
'start/*/end'still matches'start/middle/end', but you need'start/**/end'if you want to match'start/on/the/way/to/the/end'Closes #833
Maintainers
Please ensure that you check for:
serial number
corresponding change is reviewed and there is a release plan
corresponding change is reviewed and there is a release plan