Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add lock #19

Merged
merged 2 commits into from
Jun 4, 2024
Merged

add lock #19

merged 2 commits into from
Jun 4, 2024

Conversation

AlexStocks
Copy link

No description provided.

v.RefreshOpStats(i)
func() {
cmdstats.opmapLock.RLock()
defer cmdstats.opmapLock.RUnlock()
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里不能用defer, 这是一个死循环,不能用Lock

@chejinge chejinge merged commit 3651017 into chejinge:add_metrix Jun 4, 2024
1 of 2 checks passed
chejinge pushed a commit that referenced this pull request Jun 4, 2024
This reverts commit 3651017, reversing
changes made to 12a3ccc.
chejinge added a commit that referenced this pull request Jun 6, 2024
* removed keys_mutex.unlock() (OpenAtomFoundation#2657)

Co-authored-by: cjh <[email protected]>

* add metricx

* fix

* fix

* fix

* change import

* fix flag

* add lock

* fix:code style

* fix CI

* Revert "Merge branch 'add_metrix' into add_metrix"

This reverts commit 4202962, reversing
changes made to 69069e2.

* Revert "Merge pull request #19 from AlexStocks/add_metrix"

This reverts commit 3651017, reversing
changes made to 12a3ccc.

* add_metricx

* fix lock

* fix panic

* fix

* fix review comment

* fix:comment

* fix cmdinfo

---------

Co-authored-by: cheniujh <[email protected]>
Co-authored-by: cjh <[email protected]>
Co-authored-by: chejinge <[email protected]>
Co-authored-by: alexstocks <[email protected]>
Co-authored-by: Xin.Zh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants