-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
packaging variables #140
Labels
Comments
That's why we only check It seems that you already find some good enough suggestions: |
The easiest solution I can find is that set default process.env.NODE_ENV = process.env.NODE_ENV || 'production'; @mmahalwy What do you think? |
chentsulin
added a commit
that referenced
this issue
Mar 2, 2016
Close #140, set default NODE_ENV to production
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I see we have checks for node_env to be development or not, but process envs don't get packaged in (for example, I packaged with production NODE_ENV). Thoughts about this?
The text was updated successfully, but these errors were encountered: