feat: Use jpype instead of subprocess #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chezou
commented
Aug 27, 2023
| @@ -22,4 +22,6 @@ def lint(session): | |||
| @nox.session | |||
| def tests(session): | |||
| session.install(".[test]") | |||
| session.run("pytest", "-v") | |||
| session.run("pytest", "-v", "tests/test_read_pdf_table.py") | |||
| session.run("pytest", "-v", "tests/test_read_pdf_jar_path.py") | |||
There was a problem hiding this comment.
This is due to jpype limitation that doesn not allow shutdown JVM. Hence, we need to make separate session run for JVM option testing.
There was a problem hiding this comment.
This is due to jpype limitation that doesn not allow shutdown JVM
how about jpype.shutdownJVM()?
There was a problem hiding this comment.
According to the document, we have to reboot Python to relaunch JVM.
https://jpype.readthedocs.io/en/latest/api.html#jpype.shutdownJVM
Due to limitations in the JPype, it is not possible to restart the JVM after being terminated.
This was referenced Aug 27, 2023
|
The comparison of test running time is roughly 2.7 times faster than subprocess. master branch: $ Measure-Command { pytest .\tests\test_read_pdf_table.py }
Days : 0
Hours : 0
Minutes : 0
Seconds : 32
Milliseconds : 298
Ticks : 322984726
TotalDays : 0.000373824914351852
TotalHours : 0.00897179794444444
TotalMinutes : 0.538307876666667
TotalSeconds : 32.2984726
TotalMilliseconds : 32298.4726This PR: Measure-Command { pytest .\tests\test_read_pdf_table.py; pytest .\tests\test_read_pdf_jar_path.py ; pytest .\tests\test_read_pdf_silent.py }
Days : 0
Hours : 0
Minutes : 0
Seconds : 12
Milliseconds : 47
Ticks : 120479953
TotalDays : 0.000139444390046296
TotalHours : 0.00334666536111111
TotalMinutes : 0.200799921666667
TotalSeconds : 12.0479953
TotalMilliseconds : 12047.9953 |
chezou
changed the title
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Close #352
Successor of #355
Motivation and Context
To reduce JVM launch overhead for each execution.
How Has This Been Tested?
Unit test.
Screenshots (if appropriate):
Types of changes
Checklist: