Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Fall back to subprocess if jpype fails #359

Merged
merged 1 commit into from
Sep 22, 2023
Merged

Conversation

chezou
Copy link
Owner

@chezou chezou commented Sep 22, 2023

Description

jpype triggers weird errors in specific environments #352 (comment)
This patch allows to fallback to subprocess when jpype import fails.

Bonus: add force_subprocess option to enforce using subprocess.

Motivation and Context

To add workaround for jpype issue.

How Has This Been Tested?

unit test

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I read the contributing document.
  • My code follows the code style of this project with running linter.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@chezou chezou merged commit dd9d111 into master Sep 22, 2023
2 checks passed
@chezou chezou deleted the fallback-subprocess branch September 22, 2023 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant