Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typescript): fix proxyRes and router types #410

Merged
merged 4 commits into from
Feb 29, 2020

Conversation

dylang
Copy link
Contributor

@dylang dylang commented Feb 27, 2020

@ghost
Copy link

ghost commented Feb 27, 2020

Congratulations 🍻. DeepCode analyzed your code in 0.104 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

💬 This comment has been generated by the DeepCode bot, installed by the owner of the repository. The DeepCode bot protects your repository by detecting and commenting on security vulnerabilities or other critical issues.


☺️ If you want to provide feedback on our bot, here is how to contact us.

@coveralls
Copy link

coveralls commented Feb 27, 2020

Coverage Status

Coverage remained the same at 88.052% when pulling 0562c57 on dylang:fix-proxyRes-types into 47608aa on chimurai:master.

@dylang
Copy link
Contributor Author

dylang commented Feb 28, 2020

Hi @chimurai, any changes you want to this?

README.md Show resolved Hide resolved
@chimurai
Copy link
Owner

chimurai commented Feb 28, 2020

Great work! Just one comment on the documentation.

Other than that. LGTM 👍

@chimurai chimurai changed the title fix(typescript): fix proxyRes, router, README.md fix(typescript): fix proxyRes and router types Feb 29, 2020
@chimurai chimurai merged commit 6d30314 into chimurai:master Feb 29, 2020
@chimurai
Copy link
Owner

published v1.0.1 to npm

Thanks for helping out with the types!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants