Preventing the fail of the 'ETIMEDOUT' code in 500 'Internal server error' #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chimurai could you please review this PR? |
|
Can someone review and merge this PR? |
|
Can you add https:/chimurai/http-proxy-middleware/blob/master/test/unit/handlers.spec.ts#L101 |
|
Oops, missed that. 🙈 |
|
Thanks for this PR! |
|
Could you please let me know when the new version would be available on the npm? |
sarumont
pushed a commit
to sarumont/http-proxy-middleware
that referenced
this pull request
Jan 12, 2021
…rror' (chimurai#480) Thanks for this PR!
|
Published in v1.1.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
ETIMEDOUTcode is handled by thedefaultErrorHandleras a[500] Internal Server Error.It should be handled as the regular
ECONNRESET||ENOTFOUND||ECONNREFUSED||ETIMEDOUTcodes.