Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thumbnail image path for page bundles. #72

Closed
rugginic opened this issue Nov 2, 2020 · 11 comments
Closed

Thumbnail image path for page bundles. #72

rugginic opened this issue Nov 2, 2020 · 11 comments
Assignees
Labels
enhancement New feature or request

Comments

@rugginic
Copy link

rugginic commented Nov 2, 2020

Hello and thank you for this amazing theme.
I'd like to ask 3 questions I couldn't find an answer for in the documentation:

  1. I'm trying to keep posts and their resources (images, attachments, ecc) within the content folder, leveraging page bundles. One thing I noticed, the thumbnail image path apparently always points to the static folder. I couldn't manage to keep all the post's content within the same post folder "/content/post/2020-10-10-post-title-folder/"
    is there a way to do so? or am I missing something? what would be the best practice in terms of content management?

  2. what would be the best way to customise the theme (color scheme, fonts, ecc)

  3. I noticed the theme does not have "reading time" for articles and internal search option to search through the posts. I wonder a scenario where I have hundreds of posts in my blog and and I want to search for a word or a phrase. How would one achieve this?

Thanks and Regards,
Nicola

@chipzoller
Copy link
Owner

Hello, Nicola. I can handle the third question while the other two would be better answered by @onweru. We currently have not implemented a search function, however this is planned in the 2.0 milestone via a custom implementation. The "reading time" function you mentioned is a separate piece of functionality if you're asking about blogs that state something like "estimated 5 minutes to read" up front. This isn't something that a search function would solve, however.

@rugginic
Copy link
Author

rugginic commented Nov 3, 2020

Hello Chip! Thanks for coming back to me! You are right, In fact my 3rd question was a kind of "feature request" for 2 separate features:

  1. Reading time as many other themes already have. Exactly what you are referring to: "estimated reading time" nice to have for a casual reader who has 5 spare minutes and might not start reading an article that takes an average of 30 minutes to read (or vice versa!)
  2. The second is for implementing search through articles. I read that it is planned for v2.0 release and also here someone has already implemented a custom search page, that could do for me while waiting for the official release!

Just out of curiosity, what is your approach in terms of page resources? When you publish a new post that has a bunch of screenshots, thumbnail, featured image and possibly search image, do you use the "static folder" for images and other content? and "content folder" only for the MDs?

Thanks,
Nicola

@chipzoller
Copy link
Owner

The first feature is something we aren't planning to implement at this time, but of course that's subject to change especially if there's more interest. The second feature, as I said, will get implemented in 2.0. That will probably be a next year target.

For page resources, the convention in Hugo is to separate static files from text content because images, icons, etc don't get rendered by Hugo while text (in the form of MD) does. So for my own blog, I create a dir for the year-month followed by a year for the post title. I do this for both content and static sides. Separating that content also helps in some CI/CD processes where changes occur in only one directory while leaving images be.

@onweru
Copy link
Collaborator

onweru commented Nov 3, 2020

@rugginic,

what would be the best way to customise the theme (color scheme, fonts, ecc)

I believe that is covered, to a good degree, in the readme

do you use the "static folder" for images and other content? and "content folder" only for the MDs?

That's exactly right.

I'm trying to keep posts and their resources (images, attachments, ecc) within the content folder, leveraging page bundles.

I'm familiar with the concept of page bundles, but I have so far ignored them to an obvious fault. Nonetheless for a good reason; I find media management on forestry cms (most SSG cms) painful when Hugo page resources are applied. I'll give this some thought, and if the theme can support page bundles simultaneously, I'll add support. Thanks for raising this.

@onweru onweru added the enhancement New feature or request label Nov 3, 2020
@rugginic
Copy link
Author

rugginic commented Nov 4, 2020

@onweru Thank you,

I believe that is covered, to a good degree, in the readme

yes, you are right. is it covered in the readme, and my apologies if I'm asking silly questions, I guess this is more related to git and workflow instead of this theme: I wanted to change the background color and, following the instruction I modifies _variables.sass, but now git complains about untracked changes for the submodule.
I know I could just clone the repository instead of adding the submodule, but in this way, wouldn't I miss the chance to update the theme in the future when a new release is available?

I find media management on forestry cms (most SSG cms) painful when Hugo page resources are applied.

Sorry, I'm not sure I understand how forestry is related. For my understanding, image processing was introduced in hugo for the purpose to help manage images on page bundles, right? That's why image processing only applies to images within the "content" folder, as per Hugo guidelines on Content Management.

@chipzoller Thank you,

For page resources, the convention in Hugo is to separate static files from text content

I'm confused, Isn't it contradicting the concept of Page Bundles?

@chipzoller
Copy link
Owner

Yes, that's the concept of Page Bundles, but they're a (fairly) new concept to Hugo. Prior to Page Bundles, the convention was that non-rendered files (typically images) should be defined in /static which is what we're currently doing. Bundles are certainly something I'd like to see, but that's just going to take a little time.

@rugginic
Copy link
Author

rugginic commented Nov 5, 2020

@onweru

Pro Tip: You can change the theme colors via the this variable's SASS file

How do one overrides the _variables.sass or creates a custom .sass outside the them folder? I'm quite happy with changing $bg and $theme colors and I think I tried almost everything but I can't manage to change those settinngs leaving the theme's folder untouched. Can you please help?

onweru pushed a commit that referenced this issue Nov 9, 2020
onweru pushed a commit that referenced this issue Nov 9, 2020
@onweru
Copy link
Collaborator

onweru commented Nov 9, 2020

@rugginic, I have updated the readme accordingly to accommodate your question. It might be helpful to look at the comments embedded in the files affected by 714a461 as well

@onweru
Copy link
Collaborator

onweru commented Nov 9, 2020

One more thing, to add new font files use these wonderful templates that were added by @razonyang at #50

@rugginic
Copy link
Author

@onweru Thanks a lot!
I maneged to override the colors creating /assets/sass/_override.sass !!
Just a heads up:

// we recommend not editing this file directly. Instead, create an assets/sass/override.sass file at the root level of your site.

In my case it didn't work without the "_" underscore. The file has to be renamed _override.sass

@onweru
Copy link
Collaborator

onweru commented Nov 13, 2020

@rugginic, thanks for catching that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants