Skip to content
This repository has been archived by the owner on Sep 30, 2024. It is now read-only.

Add Migration.kt #114

Merged
merged 2 commits into from
Nov 12, 2021
Merged

Add Migration.kt #114

merged 2 commits into from
Nov 12, 2021

Conversation

osipxd
Copy link
Contributor

@osipxd osipxd commented Jun 20, 2021

Closes #113

@chrisbanes chrisbanes enabled auto-merge (squash) July 20, 2021 11:56
@chrisbanes
Copy link
Owner

Thanks 🙌

@chrisbanes
Copy link
Owner

Looks like there's some code style issues. Please run: ./gradlew spotlessApply apiDump and commit the changes.

auto-merge was automatically disabled July 20, 2021 17:22

Head branch was pushed to by a user without write access

@osipxd osipxd requested a review from chrisbanes July 20, 2021 17:24
@chrisbanes chrisbanes enabled auto-merge (squash) July 21, 2021 07:19
@osipxd
Copy link
Contributor Author

osipxd commented Jul 21, 2021

Hmm... I've added @Supress("unused") but looks like the compiler with the flag -Werror ignores it.
Do you know any way to ignore warnings in this code?

@chrisbanes
Copy link
Owner

Hmm... I've added @Supress("unused") but looks like the compiler with the flag -Werror ignores it.
Do you know any way to ignore warnings in this code?

The problem is that the params aren't used. @Suppress("unused") only suppresses the fact that function isn't used.

You can fix it by using @Suppress("unused", "UNUSED_PARAMETER") (I think)

auto-merge was automatically disabled July 21, 2021 12:19

Head branch was pushed to by a user without write access

@osipxd
Copy link
Contributor Author

osipxd commented Jul 21, 2021

The problem is that the params aren't used. @Suppress("unused") only suppresses the fact that function isn't used.

You can fix it by using @Suppress("unused", "UNUSED_PARAMETER") (I think)

Yes, you're right, it works.
I thought unused is some kind of super-class for UNUSED_PARAMETER and UNUSED_VARIABLE

@chrisbanes chrisbanes enabled auto-merge (squash) November 12, 2021 09:05
@chrisbanes chrisbanes merged commit c5cf221 into chrisbanes:main Nov 12, 2021
@osipxd osipxd deleted the feature/migration branch November 12, 2021 11:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migration from 0.3.1 to 0.6.0
3 participants