Provide solution for dealing with ref problem when using HOC #399
Conversation
aesopwolf
changed the title
There was a problem hiding this comment.
Looks good, nicely done! The only thing I could spot was a wonky camelCase on getWrappedInstance in the test description. Not a biggy but might help searchability :) Thanks for the PR @aesopwolf 👍
|
pinging @christianalfoni do you need additional maintainers for this project? |
|
I came across a different approach that might be slightly better, which is to pass a prop called What do you think @christianalfoni? |
|
@Semigradsky are you able to chime in here and help approve this? |
|
Is there any movement on this? I'm seeing this as a blocker to being able to reset a multi checkbox group of checkbox inputs to their initial state. While this.refs.form.reset() will reset the overall form value to that initial state, the HOC wrapped checkboxes still remain checked. |
|
No movement. I haven't heard anything from the maintainers since opening the PR. They seem to have abandoned the project.
I'm debating forking it and getting a majority of the other PR's merged in as well.
… On Nov 23, 2016, at 3:49 PM, Brian Fegan ***@***.***> wrote:
Is there any movement on this? I'm seeing this as a blocker to being able to reset a multi checkbox group of checkbox inputs to their initial state. While this.refs.form.reset() will reset the overall form value to that initial state, the HOC wrapped checkboxes still remain checked.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
I pulled the trigger and forked the repo. I published it to npm under You can check it out here: I think I'll make an issue to advertise the new fork and it's location. |
|
I was given write access to the repo (see #411). So I'm going to reopen this PR and get it merged in. |
This reverts commit 667ac8c.
* christ/master: v0.19.2 Revert "fix: show the default validation message when there is a required error (christianalfoni#386)" v0.19.1 fix: show the default validation message when there is a required error (christianalfoni#386) Remove stray sentence. (christianalfoni#415) Update API.md Fix crash when comparing array with null (christianalfoni#404) docs: Removing unnecessary single quote (christianalfoni#410) 0.19.0 feat: expose inner element when using HOC (christianalfoni#399) Update README.md Update LICENSE Nit-picky typo
Add method to expose the wrapped instance when using the HOC (higher order component)
It's
ref's all the way down. This closes #308, closes #341