Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(x-pack/filebeat): add unit test for s3-sns-sqs #1

Merged
merged 1 commit into from
Jun 7, 2021
Merged

test(x-pack/filebeat): add unit test for s3-sns-sqs #1

merged 1 commit into from
Jun 7, 2021

Conversation

thomasklinger1234
Copy link

What does this PR do?

Adding unit tests for consuming AWS SQS messages sent via AWS SNS and S3.

Why is it important?

Unit tests were not complete for upstream change elastic#25492.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

@christianherweg0807 christianherweg0807 merged commit ae557fa into christianherweg0807:awss3_sns_sqs Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants