[CLN] ServerAPI to use Collection model

[atroyn]

Description of changes

This PR refactors the ServerAPI classes so that their methods only return the Collection model, not the Collection object itself, i.e. the view on the data.

This is a much cleaner separation of concerns than we had before, and should enable faster iteration in parts. For example, the ServerAPI no longer needs to know about EmbeddingFunction or DataLoader etc - these only exist for Clients.

We will probably re-add them when we start moving some of that functionality server-side for cloud, but for now this is a fine solution.

Most the LoC in this PR are changing tests to use the ClientAPI and fixture instead of the ServerAPI and fixture. This does put the client in the line, but I think this is fine.

Test plan

Tests pass in CI.

Documentation Changes

N/A

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
chroma	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 6, 2024 8:19pm

[github-actions]

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

• Can you think of any use case in which the code does not behave as intended? Have they been tested?
• Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
• If appropriate, are there adequate property based tests?
• If appropriate, are there adequate unit tests?
• Should any logging, debugging, tracing information be added or removed?
• Are error messages user-friendly?
• Have all documentation changes needed been made?
• Have all non-obvious changes been commented?

System Compatibility

• Are there any potential impacts on other parts of the system or backward compatibility?
• Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

• Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

[atroyn]

• [CLN] ServerAPI to use Collection model #2300 : 2 dependent PRs (#2265 , #2338 ) 👈
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @atroyn and the rest of your teammates on Graphite

[github-actions]

Please tag your PR title with one of: [ENH | BUG | DOC | TST | BLD | PERF | TYP | CLN | CHORE]. See https://docs.trychroma.com/contributing#contributing-code-and-ideas

[HammadB]

I think the change in test_persist may be an accident? Otherwise just a clean up nit and looks great

[atroyn]

Merge activity

• Jul 8, 11:00 PM EDT: @atroyn started a stack merge that includes this pull request via Graphite.
• Jul 8, 11:01 PM EDT: @atroyn merged this pull request with Graphite.