Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] fix: add github link and update discord invite link #2387

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

zacatac
Copy link
Contributor

@zacatac zacatac commented Jun 20, 2024

Description of changes

Updates docs to:

  • adds a link Github issues on the migrations page
  • updates the discord invite link (seems the other one expired)

Test plan

previewed the markdown locally and links worked.

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?

n/a didn't update these

Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

Copy link
Contributor

@tazarov tazarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for this @zacatac

@jeffchuber jeffchuber merged commit 107e725 into chroma-core:main Jun 24, 2024
10 checks passed
@jeffchuber
Copy link
Contributor

@zacatac thanks!

Anush008 pushed a commit to Anush008/chroma that referenced this pull request Jun 27, 2024
…e#2387)

## Description of changes

Updates docs to:
* adds a link Github issues on the migrations page
* updates the discord invite link (seems the other one expired)

## Test plan
previewed the markdown locally and links worked.

## Documentation Changes
*Are all docstrings for user-facing APIs updated if required? Do we need
to make documentation changes in the [docs
repository](https:/chroma-core/docs)?*

n/a didn't update these

Co-authored-by: Zack Field <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants