Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] return chroma-trace-id header, include trace ID in thrown errors #2570

Merged
merged 6 commits into from
Jul 24, 2024

Conversation

codetheweb
Copy link
Contributor

@codetheweb codetheweb commented Jul 24, 2024

Returns a new chroma-trace-id header for both successful and errored responses.

Tested locally with Jaeger.

Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@codetheweb codetheweb marked this pull request as ready for review July 24, 2024 17:14
Copy link
Collaborator

@HammadB HammadB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we follow this convention?

https://www.w3.org/TR/trace-context/

chromadb/test/test_api.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@HammadB HammadB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! We can always munge to standards later if we want, I linked that for reference.

@codetheweb
Copy link
Contributor Author

Should we follow this convention?

w3.org/TR/trace-context

interesting, it seems like this is focused on forwarding trace context upstream rather than returning it downstream though

@HammadB
Copy link
Collaborator

HammadB commented Jul 24, 2024 via email

@codetheweb codetheweb enabled auto-merge (squash) July 24, 2024 20:51
@codetheweb codetheweb merged commit fbb4ef4 into main Jul 24, 2024
65 checks passed
@codetheweb codetheweb deleted the feat-trace-id-header branch July 24, 2024 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants