[ENH] Synchronize post s3.get() operations in providers #2712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @sanketkedia and the rest of your teammates on |
sanketkedia
changed the title
sanketkedia
force-pushed
the
08-22-synchronize_post_s3.get_operation_in_providers
branch
from
7d3cacb
to
ee24084
Compare
sanketkedia
force-pushed
the
08-22-synchronize_post_s3.get_operation_in_providers
branch
from
ee24084
to
e265224
Compare
spikechroma
pushed a commit
that referenced
this pull request
Sep 12, 2024
## Description of changes *Summarize the changes made by this PR.* Adds synchronization points in hnsw_provider and blockfile provider for concurrent cache inserts to the same key. This prevents dangling references to entries that the cache is not aware of. For the HNSW provider, we also synchronize writing out the index byte buffer to the local files since that is not guaranteed to be thread safe. ## Test plan - [x] Tests pass locally with `pytest` for python, `yarn test` for js, `cargo test` for rust ## Documentation Changes None
spikechroma
pushed a commit
that referenced
this pull request
Sep 12, 2024
*Summarize the changes made by this PR.* Adds synchronization points in hnsw_provider and blockfile provider for concurrent cache inserts to the same key. This prevents dangling references to entries that the cache is not aware of. For the HNSW provider, we also synchronize writing out the index byte buffer to the local files since that is not guaranteed to be thread safe. - [x] Tests pass locally with `pytest` for python, `yarn test` for js, `cargo test` for rust None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Summarize the changes made by this PR.
Adds synchronization points in hnsw_provider and blockfile provider for concurrent cache inserts to the same key. This prevents dangling references to entries that the cache is not aware of. For the HNSW provider, we also synchronize writing out the index byte buffer to the local files since that is not guaranteed to be thread safe.
Test plan
pytestfor python,yarn testfor js,cargo testfor rustDocumentation Changes
None