[CHORE] Make a ChromaError type for RuntimeTypeError #2866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
rescrv
force-pushed
the
rescrv/fix-error-type
branch
from
ddd76d0
to
754cb14
Compare
HammadB
reviewed
Sep 26, 2024
rust/blockstore/src/key.rs
Outdated
| // TODO(rescrv): This used to be a panic/unwrap, but could be a nicer type. | ||
| #[derive(thiserror::Error, Debug)] | ||
| #[error("runtime type error")] | ||
| pub struct RuntimeTypeError; |
There was a problem hiding this comment.
Maybe "InvalidKeyConversion"?
There was a problem hiding this comment.
Naming is hard. Thank you for doing the hard work :-)
HammadB
reviewed
Sep 26, 2024
| while let Some((_, index)) = self.cache.pop() { | ||
| let index_id = index.inner.read().id; | ||
| /// Purge entries from the cache by index ID and remove temporary files from disk. | ||
| pub async fn purge_by_id(&mut self, index_ids: &[Uuid]) { |
There was a problem hiding this comment.
i think some wires from another PR may have gotten crossed here?
There was a problem hiding this comment.
Wrong base. Updated.
rescrv
force-pushed
the
rescrv/fix-error-type
branch
from
378f0b5
to
7023f2e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Summarize the changes made by this PR.
Test plan
How are these changes tested?
cargo check+ CIDocumentation Changes
Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?