Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow restricted IPs to be added with an override flag #98

Open
1 task
mcdonnnj opened this issue Jul 8, 2024 · 0 comments · May be fixed by #99
Open
1 task

Allow restricted IPs to be added with an override flag #98

mcdonnnj opened this issue Jul 8, 2024 · 0 comments · May be fixed by #99
Labels
improvement This issue or pull request will add new or improve existing functionality

Comments

@mcdonnnj
Copy link
Member

mcdonnnj commented Jul 8, 2024

💡 Summary

We need to provide a flag that will allow users of the cyhy-ip tool to add restricted IPs if desired.

Motivation and context

Although generally undesirable there are specific scenarios where this is necessary. The most common is if a restricted IP is removed while a scan for the IP is in progress. When the scan completes it may cause host information for the remote IP to be updated (including re-opening tickets). The cleanest way to resolve this is to re-add and then remove the affected IP to ensure any re-opened tickets are once again closed. Currently this is not readily possible using the provided tools.

Implementation notes

This should only bypass the final check to fail if restricted IPs are provided. It should still output all logging information that informs a user that a restricted IP is included and warn that a restricted IP will be added to the database. We should also add the same flag to cyhy-tool to ensure parity between the tools.

Acceptance criteria

  • There is a flag available that will allow restricted IPs to be added to the database.
@mcdonnnj mcdonnnj added the improvement This issue or pull request will add new or improve existing functionality label Jul 8, 2024
@mcdonnnj mcdonnnj linked a pull request Jul 10, 2024 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement This issue or pull request will add new or improve existing functionality
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

1 participant