Change packer_fmt to write to files by default
#48
+5
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of providing default arguments to the `packer_fmt` hook we instead use the default behavior of the `packer fmt` command. This will result in files being written to if formatting is needed instead of just warning that a file is improperly formatted. An important note is that `packer fmt` returns 0 even if changing a file with the default arguments. The existing exit code check is left in place in case the arguments for the hook are changed.
mcdonnnj
added
breaking change
jsf9k
approved these changes
Oct 18, 2024
dv4harr10
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pull request changes the
packer_fmthook to use the default behavior of thepacker fmtcommand instead of providing arguments. This results in the hook writing changes to files instead of failing and outputting paths that failed to pass a format check.💭 Motivation and context
This mirrors the behavior of the
terraform_fmthook we use from antonbabenko/pre-commit-terraform and in retrospect makes the most sense for the hook's behavior.🧪 Testing
Automated tests pass. I confirmed the expected functionality with the pre-release.
✅ Pre-approval checklist
to reflect the changes in this PR.
✅ Pre-merge checklist
✅ Post-merge checklist