Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Rust Toolchain: jemalloc or the system allocator #256

Closed
yangby-cryptape opened this issue Feb 25, 2019 · 7 comments
Closed

Upgrade Rust Toolchain: jemalloc or the system allocator #256

yangby-cryptape opened this issue Feb 25, 2019 · 7 comments
Assignees
@yangby-cryptape
Labels
call for participation help wanted Extra attention is needed p:should-have Important but not necessary for current development
Milestone
v0.23

Comments

@yangby-cryptape
Copy link
Contributor

According to the official rust blog: jemalloc is removed by default since rust v1.32.0.

The rust v1.33.0 is coming. The rust v1.33.0 release pr was created few minutes ago.

So, any plan to upgrade the rust toolchain? And, jemalloc or the system allocator?
@kaikai1024
Copy link
Contributor

yeah. Will upgrade the toolchain to the latest stable version at v1.0.

I'm not sure about jemalloc or the system allocator.

@yangby-cryptape
Copy link
Contributor Author

Rust 1.33.0 has been released.

@kaikai1024 kaikai1024 added the help wanted Extra attention is needed label Mar 4, 2019
@kaikai1024
Copy link
Contributor

kaikai1024 commented Mar 4, 2019 •
edited
Loading

image: cita/cita-build:ubuntu-18.04-20190304

@kaikai1024 kaikai1024 added the p:should-have Important but not necessary for current development label Mar 7, 2019
@boundless-forest boundless-forest self-assigned this Mar 8, 2019
@kaikai1024 kaikai1024 added this to the v1.0.0-alpha milestone Mar 13, 2019
@yangby-cryptape yangby-cryptape mentioned this issue Mar 17, 2019
Merged
@kaikai1024 kaikai1024 reopened this Mar 18, 2019
@kaikai1024
Copy link
Contributor

I'd like to continue to use the jemalloc. @yangby-cryptape

@kaikai1024
Copy link
Contributor

rust-lang/rust#36963 (comment)

@kaikai1024
Copy link
Contributor

I'd like to continue to use the jemalloc

TBD. Will decide it after check the performance

@kaikai1024
Copy link
Contributor

tps: 4410 -> 4338
That's acceptable. use system allocator.
jemalloc still is a choice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yangby-cryptape yangby-cryptape

Labels
call for participation help wanted Extra attention is needed p:should-have Important but not necessary for current development
Projects
None yet
Milestone
v0.23
Development

No branches or pull requests
3 participants
@kaikai1024 @boundless-forest @yangby-cryptape