tweak(vendor/range-v3): Merge with upstream #2837
Open
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSVC (v14.41-17.11) does not drag-in 'std::basic_string' when referencing '<string_view>'. An upstream commit fixed this by now including proper <string> headers. Related MSFT STL changeset: microsoft/STL@cce32f4
github-actions
bot
added
the
triage
FabianTerhorst
approved these changes
Oct 4, 2024
4 tasks
FabianTerhorst
added
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal of this PR
MSVC (v14.41-17.11) stopped draggin-in 'std::basic_string' when referencing '<string_view>'. This breaks building on any MSVC version >= v14.41-17.11
How is this PR achieving the goal
An upstream commit (ericniebler/range-v3@3346e2b) fixed this by now including proper 'string' headers.
Related MSFT STL changeset: microsoft/STL@cce32f4
Upstream changes were tested and did not affect project usage.
This is a proper fix to the temporary fix included in: #2836
This PR applies to the following area(s)
Building
Successfully tested on
Game builds: Not applicable
Platforms: Windows, Linux, Github Actions
Checklist
Fixes issues
/